NTP BUG 3383: Stack Buffer Overflow from Command Line (WINDOWS installer ONLY)
Last update: February 16, 2022 15:54 UTC (b0750def8)
The Windows installer for NTP calls
strcat(), blindly appending the string passed to the stack buffer in the
addSourceToRegistry() function. The stack buffer is 70 bytes smaller than the buffer in the calling
main() function. Together with the initially copied Registry path, the combination causes a stack buffer overflow and effectively overwrites the stack frame. The passed application path is actually limited to 256 bytes by the operating system, but this is not sufficient to assure that the affected stack buffer is consistently protected against overflowing at all times.
This weakness was discovered by Cure53.